Skip to content

config: Compatible with low-version browsers. #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

space-77
Copy link

@space-77 space-77 commented Apr 7, 2025

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Apr 7, 2025

⚠️ No Changeset found

Latest commit: 19443a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 19443a4
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67f32c9b2c9c1f0008eda5da
😎 Deploy Preview https://deploy-preview-6458--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Apr 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6458
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6458
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6458
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6458

commit: 19443a4

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.86%. Comparing base (ceb8d4c) to head (19443a4).

Files with missing lines Patch % Lines
.esbuild/util.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6458      +/-   ##
==========================================
- Coverage     3.86%   3.86%   -0.01%     
==========================================
  Files          411     412       +1     
  Lines        43178   43190      +12     
  Branches       664     664              
==========================================
  Hits          1670    1670              
- Misses       41508   41520      +12     
Flag Coverage Δ
unit 3.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.esbuild/util.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

argos-ci bot commented Apr 7, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ Auto-approved build - Apr 7, 2025, 1:48 AM

@sidharthv96
Copy link
Member

sidharthv96 commented Apr 7, 2025

Hi @space-77, can you share if you have tested the updated outputs with any specific browsers?
Also, which browsers are you trying to support? Because, the target parameter will only do limited transpilation.

Note that this is only concerned with syntax features, not APIs. It does not automatically add polyfills for new APIs that are not used by these environments.

From https://esbuild.github.io/api/#target


Semi related, We should setup a browserlist query for mermaid, to specify which browsers we support, and lint rules to catch unsupported features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants