-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
config: Compatible with low-version browsers. #6458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6458 +/- ##
==========================================
- Coverage 3.86% 3.86% -0.01%
==========================================
Files 411 412 +1
Lines 43178 43190 +12
Branches 664 664
==========================================
Hits 1670 1670
- Misses 41508 41520 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Hi @space-77, can you share if you have tested the updated outputs with any specific browsers?
From https://esbuild.github.io/api/#target Semi related, We should setup a browserlist query for mermaid, to specify which browsers we support, and lint rules to catch unsupported features. |
📑 Summary
Brief description about the content of your PR.
Resolves #
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.