-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Feat: Add editor popup modal #6609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6609 +/- ##
=========================================
- Coverage 3.84% 3.84% -0.01%
=========================================
Files 413 414 +1
Lines 43399 43407 +8
Branches 666 666
=========================================
Hits 1670 1670
- Misses 41729 41737 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
packages/mermaid/src/docs/.vitepress/components/EditorSelectionModal.vue
Outdated
Show resolved
Hide resolved
…ajat-ht/feat-add-editor-popup-modal
v-for="(column, index) in editorColumns" | ||
:key="index" | ||
class="w-80 flex relative flex-col items-center justify-start bg-[#dceef1] p-6 m-6 text-gray-800 shadow-sm" | ||
:class="index === 1 ? 'bg-white rounded-b-lg' : 'bg-[#DCEEF1] rounded-lg'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using index here, use a boolean flag in the column object, like highlighted: true
.
Remove all the use of index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 5fe0f53
📑 Summary
This PR contains adds Editor popup modal.
📏 Design Decisions
Design decisions made by the Mermaid Chart team.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.