Skip to content

Feat: Add editor popup modal #6609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 28, 2025
Merged

Conversation

rajat-ht
Copy link
Collaborator

📑 Summary

This PR contains adds Editor popup modal.

📏 Design Decisions

Design decisions made by the Mermaid Chart team.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented May 21, 2025

⚠️ No Changeset found

Latest commit: ef449a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 143 lines in your changes missing coverage. Please review.

Project coverage is 3.84%. Comparing base (f23a26e) to head (ef449a6).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...ocs/.vitepress/components/EditorSelectionModal.vue 0.00% 138 Missing ⚠️
...ackages/mermaid/src/docs/.vitepress/theme/index.ts 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6609      +/-   ##
=========================================
- Coverage    3.84%   3.84%   -0.01%     
=========================================
  Files         413     414       +1     
  Lines       43399   43407       +8     
  Branches      666     666              
=========================================
  Hits         1670    1670              
- Misses      41729   41737       +8     
Flag Coverage Δ
unit 3.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/mermaid/src/docs/.vitepress/theme/index.ts 2.38% <0.00%> (ø)
...ocs/.vitepress/components/EditorSelectionModal.vue 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

argos-ci bot commented May 21, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - May 28, 2025, 4:37 PM

@sidharthv96 sidharthv96 self-assigned this May 22, 2025
@rajat-ht rajat-ht requested a review from sidharthv96 May 23, 2025 11:04
v-for="(column, index) in editorColumns"
:key="index"
class="w-80 flex relative flex-col items-center justify-start bg-[#dceef1] p-6 m-6 text-gray-800 shadow-sm"
:class="index === 1 ? 'bg-white rounded-b-lg' : 'bg-[#DCEEF1] rounded-lg'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using index here, use a boolean flag in the column object, like highlighted: true.
Remove all the use of index.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 5fe0f53

@rajat-ht rajat-ht requested a review from sidharthv96 May 23, 2025 11:25
@sidharthv96 sidharthv96 merged commit c4de3cd into master May 28, 2025
11 checks passed
@sidharthv96 sidharthv96 deleted the rajat-ht/feat-add-editor-popup-modal branch May 28, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants