Adjust config and JWT endpoint for 55 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oisincoveney
force-pushed
the
fix-env-files-for-55
branch
from
8fed41d to
ed2b49c
Compare
sanex3339
reviewed
May 29, 2025
| @@ -11,6 +11,7 @@ services: | |||
| MB_JWT_SHARED_SECRET: "${METABASE_JWT_SHARED_SECRET}" | |||
| MB_SETUP_TOKEN: "${PREMIUM_EMBEDDING_TOKEN}" | |||
| MB_PREMIUM_EMBEDDING_TOKEN: "${PREMIUM_EMBEDDING_TOKEN}" | |||
| MB_JWT_IDENTITY_PROVIDER_URI: "http://localhost:${AUTH_PROVIDER_PORT}/sso/metabase" | |||
There was a problem hiding this comment.
If we want to merge it right now, we have to disable e2e in this file for the main branch temporarily.
Or wait till sdk@55 is out and update SDK version in package.json.
sanex3339
approved these changes
May 29, 2025
sanex3339
force-pushed
the
fix-env-files-for-55
branch
from
9aea947 to
ece15b9
Compare
sanex3339
force-pushed
the
fix-env-files-for-55
branch
from
ece15b9 to
11709b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.