Skip to content

Confusing behavior on removing externallyProvisioned: true #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dtantsur opened this issue May 19, 2025 · 3 comments
Open

Confusing behavior on removing externallyProvisioned: true #2465

dtantsur opened this issue May 19, 2025 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@dtantsur
Copy link
Member

dtantsur commented May 19, 2025 •
edited
Loading

I'm not sure we ever intended for the externallyProvisioned field to be reset to false, but right now it explicitly causes inspection to start. Unfortunately, it cannot possibly succeed with the Ironic node in the active state:

action \"inspecting\" failed: hardware inspection failed: unexpected provision state active","errorVerbose":"unexpected provision state active

If inspection is disabled, the next state is preparing, which I suspect will fail the same way for the same reason.

We need to decide on a sane behavior in this case and probably add the scenario to e2e tests.

/kind bug
@metal3-io-bot metal3-io-bot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 19, 2025
@dtantsur
Copy link
Member Author

On thinking more about it, I think removing externallyProvisioned should result in a normal provisioned state, which then can be re-inspected or whatever.

dtantsur added a commit to dtantsur/metal3-docs that referenced this issue May 20, 2025
@dtantsur
User guide: document the current state of ExternallyProvisioned
ec28af4 
Add a new page on the externally provisioned feature.

Since moving out of the externally provisioned state does not actually
work [1], remove the corresponding transitions from the diagram.

[1] metal3-io/baremetal-operator#2465

Signed-off-by: Dmitry Tantsur <[email protected]>
@dtantsur dtantsur mentioned this issue May 20, 2025
Merged
dtantsur added a commit to dtantsur/metal3-docs that referenced this issue May 20, 2025
@dtantsur
User guide: document the current state of ExternallyProvisioned
d3471c1 
Add a new page on the externally provisioned feature.

Since moving out of the externally provisioned state does not actually
work [1], remove the corresponding transitions from the diagram.

[1] metal3-io/baremetal-operator#2465

Signed-off-by: Dmitry Tantsur <[email protected]>
dtantsur added a commit to dtantsur/metal3-docs that referenced this issue May 20, 2025
@dtantsur
User guide: document the current state of ExternallyProvisioned
0415112 
Add a new page on the externally provisioned feature.

Since moving out of the externally provisioned state does not actually
work [1], remove the corresponding transitions from the diagram.

[1] metal3-io/baremetal-operator#2465

Signed-off-by: Dmitry Tantsur <[email protected]>
dtantsur added a commit to dtantsur/baremetal-operator that referenced this issue May 20, 2025
@dtantsur
Prevent changing ExternallyProvisioned in the webhook
98c5e53 
Changing ExternallyProvisioned does not actually work. Furthermore, it
results in a host hopelessly stuck in the "inspecting" state (in my
testing, I could not even delete it). Until we sort out this issue, let
us prevent users from getting into a problem.

Workaround for: metal3-io#2465

Signed-off-by: Dmitry Tantsur <[email protected]>
@dtantsur dtantsur mentioned this issue May 20, 2025
Merged
dtantsur added a commit to dtantsur/baremetal-operator that referenced this issue May 20, 2025
@dtantsur
Prevent changing ExternallyProvisioned in the webhook
7d0c93b 
Changing ExternallyProvisioned does not actually work. Furthermore, it
results in a host hopelessly stuck in the "inspecting" state (in my
testing, I could not even delete it). Until we sort out this issue, let
us prevent users from getting into a problem.

Workaround for: metal3-io#2465

Signed-off-by: Dmitry Tantsur <[email protected]>
dtantsur added a commit to dtantsur/baremetal-operator that referenced this issue May 21, 2025
@dtantsur
Prevent changing ExternallyProvisioned in the webhook
05852d2 
Changing ExternallyProvisioned does not actually work. Furthermore, it
results in a host hopelessly stuck in the "inspecting" state (in my
testing, I could not even delete it). Until we sort out this issue, let
us prevent users from getting into a problem.

Workaround for: metal3-io#2465

Signed-off-by: Dmitry Tantsur <[email protected]>
@Rozzii
Copy link
Member

Rozzii commented May 28, 2025

We have discussed this during community meeting, there are multiple options:
Let's just document this behavior and if someone is interested in the community then feel free to fix this.
/triage accepted
/help

@metal3-io-bot
Copy link
Contributor

@Rozzii:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

We have discussed this during community meeting, there are multiple options:
Let's just document this behavior and if someone is interested in the community then feel free to fix this.
/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Metal3 - Roadmap
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dtantsur @Rozzii @metal3-io-bot