Skip to content

🌱Enable forcetypeassert linter in golangci-lint #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱Enable forcetypeassert linter in golangci-lint #2394

wants to merge 1 commit into from

Conversation

andriisoldatenko
Copy link
Contributor

What this PR does / why we need it:

This PR resolves #2357

@metal3-io-bot metal3-io-bot requested review from zaneb and zhouhao3 April 7, 2025 20:06
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign honza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 7, 2025
@metal3-io-bot
Copy link
Contributor

Hi @andriisoldatenko. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2025
tuminoid
tuminoid reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Some nolints added and one TODO.

/cc @dtantsur @lentzi90

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2025
lentzi90
lentzi90 reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the nolints as they are in the test code

pkg/provisioner/ironic/clients/updateopts_test.go
ev = c.NewValue.(string)
ev, ok := c.NewValue.(string)
require.True(t, ok)
assert.Equal(t, ev, updateOp.Value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this assert should be after the if statement as it was. Otherwise we are only checking it when the expected value is "".

pkg/provisioner/ironic/capabilities.go
Comment on lines +35 to +36
// TODO: need to double check what to return in case of bad type assert.
return bootModeCapabilities[bootMode]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. @dtantsur what do you think?

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2025
@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@zaneb zaneb Awaiting requested review from zaneb

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees
No one assigned
Labels
needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable "forcetypeassert" linter in golangci-lint
4 participants
@andriisoldatenko @metal3-io-bot @tuminoid @lentzi90