Skip to content

Mpoulson/6117 - AADPIMGroupSetting - Adds support for Entra PIM Group Settings #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: Dev
Choose a base branch
from
Open

Mpoulson/6117 - AADPIMGroupSetting - Adds support for Entra PIM Group Settings #6121

wants to merge 4 commits into from

Conversation

mpoulson
Copy link
Contributor

Pull Request (PR) description

Adds support for Entra PIM Group Settings. PIM groups are similar to PIM Roles where the membership (and owner) have settings which need to be set and managed.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@mpoulson mpoulson changed the title Mpoulson/6117 pr Mpoulson/6117 - AADPIMGroupSetting - Adds support for Entra PIM Group Settings May 23, 2025
NikCharlebois
NikCharlebois requested changes May 26, 2025
View reviewed changes
Copy link
Collaborator

@NikCharlebois NikCharlebois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. One very small fix required in the examples. Thanks

@mpoulson mpoulson requested a review from NikCharlebois May 26, 2025 20:17
NikCharlebois
NikCharlebois requested changes May 28, 2025
View reviewed changes
Copy link
Collaborator

@NikCharlebois NikCharlebois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One example still needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikCharlebois NikCharlebois NikCharlebois requested changes

@ykuijs ykuijs Awaiting requested review from ykuijs ykuijs is a code owner

@M365DSCApprover M365DSCApprover Awaiting requested review from M365DSCApprover M365DSCApprover is a code owner

@m365dscapproval m365dscapproval Awaiting requested review from m365dscapproval m365dscapproval is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Entra ID Pending Information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AADPIMGroupSettings: PIM Group Settings
2 participants
@mpoulson @NikCharlebois