Skip to content

Enable SSH Generator Feature Flag and polish UI #18814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Apr 18, 2025

Enables the SSH Dynamic Profile Generator feature flag now that the Settings UI is better equipped to handle it. Since the generator was first introduced, the settings UI has grown to include an Extensions page to disable the generator (if desired) as well as a New Tab Menu page to manage how to display the generated profiles in the dropdown.

Updated the profile generator and profile icons to use font icons (StorageNetworkWireless and PC1 respectively).

This also required a minor change to the extensions page template selector. Using our icon converter sets a font size on font icons, which results in a small icon. Removing that font size setter is risky (I tried it and it resulted in clipping font icons whenever they're used in the profile dropdowns). So instead, I just created a separate entry in the template selector that creates proper styling for the font icon if it's detected.

Closes #15007

@carlos-zamora
Copy link
Member Author

Extensions page with SSH Host Profile Generator included

@carlos-zamora carlos-zamora force-pushed the dev/cazamor/sui/ext-page/beautify branch from f650f45 to b963d60 Compare April 21, 2025 22:02
@carlos-zamora carlos-zamora force-pushed the dev/cazamor/ext-page/enable-ssh branch from 172893b to 8f66ed3 Compare April 21, 2025 22:17
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this add the SSH profiles by default already? I know we've in the past talked about adding profiles only when the user wants them, so I was wondering if we're making that part of 1.24...

Comment on lines 102 to +107
<stage>AlwaysDisabled</stage>
<alwaysEnabledBrandingTokens>
<brandingToken>Dev</brandingToken>
<brandingToken>Canary</brandingToken>
<brandingToken>Preview</brandingToken>
</alwaysEnabledBrandingTokens>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should be AlwaysEnabled then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! The SSH code is hidden behind a feature flag on Stable builds so I'm making sure we still don't expose it yet. I want to make sure the experience feels right with the Extensions page. Once the Extensions page goes to Stable, we can just remove the feature flag altogether.

WindowsInbox is also one that's omitted. Same deal there.

@carlos-zamora
Copy link
Member Author

Does this add the SSH profiles by default already? I know we've in the past talked about adding profiles only when the user wants them, so I was wondering if we're making that part of 1.24...

Yeah, the profiles are added by default, but can be managed using disabledProfileSources in the JSON or the Extensions page in the SUI.

The concept of "disabling by default" is a bit difficult here because we'd have to patch disabledProfileSources to include the SSH generator. I think the way we've handled that before is by updating defaults.json. That way anybody that has disabledProfileSources defined in their settings.json is unaffected vs those who don't have it defined inherit it.

Happy to add that change in, but I just want to make sure we have consensus. I'll start a thread.

@carlos-zamora carlos-zamora force-pushed the dev/cazamor/sui/ext-page/beautify branch from b963d60 to f25e6fe Compare April 22, 2025 22:13
@carlos-zamora carlos-zamora force-pushed the dev/cazamor/ext-page/enable-ssh branch from 8f66ed3 to 92bccdf Compare April 22, 2025 23:45
lhecker
lhecker previously approved these changes Apr 23, 2025
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold for the discussion.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 23, 2025
@carlos-zamora carlos-zamora removed the Needs-Discussion Something that requires a team discussion before we can proceed label Apr 28, 2025
Base automatically changed from dev/cazamor/sui/extensions-page to main May 28, 2025 19:03
@DHowett DHowett dismissed lhecker’s stale review May 28, 2025 19:03

The base branch was changed.

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Task It's a feature request, but it doesn't really need a major design. Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels May 28, 2025
@carlos-zamora
Copy link
Member Author

Generator icon:
image

Profile icons:
image

Some other ideas from segoe fluent icons:
image
image
image

I'm guessing we want to have the generator icon and profile icons be the same (which is an easy fix now).
@DHowett any of these stand out to you? I'm actually leaning StorageNetworkWireless or PC1. (I personally like the branding of "network")

@DHowett
Copy link
Member

DHowett commented May 30, 2025

Let's do PC1 for the profiles

@DHowett
Copy link
Member

DHowett commented May 30, 2025

oh, i'm OK with the profile and the generator having different icons!

@carlos-zamora
Copy link
Member Author

image

@carlos-zamora carlos-zamora changed the title Enable SSH Generator Feature Flag Enable SSH Generator Feature Flag and polish UI May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. zBugBash-Consider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish the SSH profile generator
3 participants