Skip to content

Adopt problems panel to use views and view containers #87243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandy081 opened this issue Dec 18, 2019 · 3 comments · Fixed by #87245
Closed

Adopt problems panel to use views and view containers #87243

sandy081 opened this issue Dec 18, 2019 · 3 comments · Fixed by #87245
Assignees
Labels
debt Code quality issues
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Dec 18, 2019

Adopt problems panel to use views and view containers

Re: #85164

Adoptions & Notes:

  • Use renderBody instead of create and layoutBody instead of layout
  • If you have public render method rename it to something else like renderContent
  • Create your own memento State - important
  • Header is rendered first and then body. But before body is rendered first and then actions (header). So please be aware of this so that you can fix if there are dependencies
  • Header actions are rendered twice now because of merging single view to header. This needs to be fixed.

Existing Before and Shall be considered now:

  • Dispose is not called on hiding panel
  • Cmd+J toggle is not focusing problems
@sandy081
Copy link
Member Author

Introduced donotShowContainerTitleWhenMergedWithContainer option to hide title when in single view which is needed for problems adoption.

donotShowContainerTitleWhenMergedWithContainer?: boolean;

@sandy081
Copy link
Member Author

sandy081 commented Dec 18, 2019

Pushed adoption changes to master and problems panel now uses views and view containers 🎉

Listed in summary what are the adoptions required.

@sandy081
Copy link
Member Author

@sbatten FYI

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant