Skip to content

Ensure language packs are installed on the server side #174622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

TylerLeonhardt
Copy link
Member

We need the language pack to be on the server side so that extensions running over there are translated correctly.

This ensures the correct language pack is installed before the ExtensionScanner (which will translate the manifest of extensions) kicks in.

Fixes #166836

We need the language pack to be on the server side so that extensions running over there are translated correctly.

This ensures the correct language pack is installed before the ExtensionScanner (which will translate the manifest of extensions) kicks in.

Fixes #166836
@TylerLeonhardt TylerLeonhardt self-assigned this Feb 16, 2023
@vscodenpa vscodenpa added this to the February 2023 milestone Feb 16, 2023
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

FYI #174671 removes the dependency from ModelService to IThemeService.

@TylerLeonhardt TylerLeonhardt merged commit d5277e8 into main Feb 17, 2023
@TylerLeonhardt TylerLeonhardt deleted the tyler/tender-swan branch February 17, 2023 15:23
@TylerLeonhardt
Copy link
Member Author

@alexdima to move things along, I'll address that in another PR

@sandy081
Copy link
Member

Change look good. Thanks for doing it.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display language change not taking effect for extensions running in remote extension host
4 participants