fix(editor): Move focus to search input in RLC #15741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 1 file and found no issues. Review PR in cubic.dev.
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
elsmr
approved these changes
May 27, 2025
Workflow Test Results 📊
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains new data that previously did not exist. |
| 35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
|
|
…ins-a-search-bar-move-the-focus-to-it
ShireenMissi
approved these changes
May 27, 2025
Workflow Test Results 📊
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
| 53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
|
|
…ins-a-search-bar-move-the-focus-to-it
ShireenMissi
approved these changes
May 28, 2025
Workflow Test Results 📊 🔴 1 Failed,
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 258 | Agent:auto-fix:openai | Workflow contains 2 deleted data. |
⚠️ Warnings (2)
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
|
✅ All Cypress E2E specs passed |
RomanDavydchuk
deleted the
node-2007-rlc-when-opening-list-that-contains-a-search-bar-move-the-focus-to-it
branch
Alexandero89
pushed a commit
to Alexandero89/n8n
that referenced
this pull request
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the default
mousedownevent behavior on the RLC input to make sure the focus stays on the search input. There is already functionality to move focus to the search input in place, but the focus would move back to the original input. This happened, because the mouse would still hover over the input and the search input rendered too quickly, which caused the browser to move the focus back. By preventingmousedownevent default behavior, the focus stays on the search inputRelated Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2007/rlc-when-opening-list-that-contains-a-search-bar-move-the-focus-to-it
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)