refactor: Simplify agent request store #15743
Open
+181
−324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic found 2 issues across 7 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
fix(editor): Simplify agentRequest store
schrothbn
force-pushed
the
ai-950-prototype-pollution-vulnerability-detected
branch
from
d577967 to
c4510f2
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
burivuhster
approved these changes
May 28, 2025
| }; | ||
| }; | ||
|
|
||
| const clearAgentRequests = (workflowId: string, nodeId: string): void => { | ||
| if (agentRequests.value[workflowId]) { | ||
| agentRequests.value[workflowId][nodeId] = {}; | ||
| agentRequests.value[workflowId][nodeId] = { query: {} }; |
There was a problem hiding this comment.
Can we just delete it instead of setting to empty content here? And maybe even delete agentRequests.value[workflowId] as well if it was the last key?
Workflow Test Results 📊
|
| Workflow ID | Workflow Name | Reason |
|---|---|---|
| 237 | BasicLLMChain:AzureChat | Workflow contains new data that previously did not exist. |
| 35 | Slack:User:getPresence info:UserProfile:get update... | Workflow contains new data that previously did not exist. |
| 257 | Agent:auto-fix:anthropic | Workflow contains new data that previously did not exist. |
| 53 | ConvertKit:CustomField:create getAll update delete... | Workflow contains new data that previously did not exist. |
|
|
…llution-vulnerability-detected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the agent request store and removes unneeded code. The store is now more focused on its intend and doesn't need complex logic to build the object that's being sent to the backend. It is making now use of
useLocalStorageinstead of handling that inside the store and naming of functions have been adjusted. This should also address a potential security vulnerability caused by the old handling.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/AI-950/prototype-pollution-vulnerability-detected
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)