fix: Close NDV using correct button (no-changelog) #15745
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing due to how Cypress runs in headless vs non headless mode. Esc not always being registered etc.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 1 file and found no issues. Review PR in cubic.dev.
The test was failing due to how Cypress runs in headless vs non headless mode. Esc not always being registered etc.
… into PAY-2815-fix-flaky-project-test
MarcL
reviewed
May 27, 2025
cypress/e2e/39-projects.cy.ts
Outdated
| getNdvContainer().should('be.visible'); | ||
| cy.get('body').type('{esc}'); | ||
| getBackToCanvasButton().click(); |
There was a problem hiding this comment.
[nit] There's also a clickGetBackToCanvas() method which does the same thing if you wanted to use that.
cypress/e2e/39-projects.cy.ts
Outdated
Comment on lines
296
to
300
| // Stub window.open before adding sub-workflow opens a new tab | ||
| cy.window().then((win) => { | ||
| cy.stub(win, 'open').as('windowOpen').returns(null); | ||
| }); | ||
|
|
There was a problem hiding this comment.
For my own (lack of) Cypress knowledge, we're now stubbing the window.open call and I assume that stops the tab from opening. How do we ensure the additional nodes are added to the sub-workflow (in the new tab)?
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing due to how Cypress runs in headless vs non headless mode. Esc not always being registered etc.
Summary
Fixes the failing project test.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-2815/flaky-ui-projects-when-starting-from-scratch-should-create-sub
Flaky Test Run: https://github.com/n8n-io/n8n/actions/runs/15274055259/job/42956066490 200 passed
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)