module: handle instantiated async module jobs in require(esm) #58067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in nodejs#57187.
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58067 +/- ##
=======================================
Coverage 90.20% 90.21%
=======================================
Files 630 630
Lines 186391 186423 +32
Branches 36612 36615 +3
=======================================
+ Hits 168134 168177 +43
+ Misses 11068 11061 -7
+ Partials 7189 7185 -4
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
joyeecheung
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58067 ✔ Done loading data for nodejs/node/pull/58067 ----------------------------------- PR info ------------------------------------ Title module: handle instantiated async module jobs in require(esm) (#58067) Author Joyee Cheung <[email protected]> (@joyeecheung) Branch joyeecheung:fix-instantiated -> nodejs:main Labels c++, lib / src, needs-ci Commits 1 - module: handle instantiated async module jobs in require(esm) Committers 1 - Joyee Cheung <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58067 Fixes: https://github.com/nodejs/node/issues/58061 Reviewed-By: Jacob Smith <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58067 Fixes: https://github.com/nodejs/node/issues/58061 Reviewed-By: Jacob Smith <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 29 Apr 2025 00:39:29 GMT ✔ Approvals: 1 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/58067#pullrequestreview-2802523383 ✘ This PR needs to wait 7 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-05-05T10:51:08Z: https://ci.nodejs.org/job/node-test-pull-request/66609/ - Querying data for job/node-test-pull-request/66609/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14841472093 |
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e0766f9 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in #57187. PR-URL: #58067 Fixes: #58061 Reviewed-By: Jacob Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When require(esm) encounters a cached module job that is instantiated but not yet evaluated, run the evaluation. This catches an edge case previously missed in #57187.
Fixes: #58061