Skip to content

async_hooks: ensure AsyncLocalStore instances work isolated #58149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

async_hooks: ensure AsyncLocalStore instances work isolated #58149

merged 3 commits into from
May 6, 2025

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented May 3, 2025

Avoid that one AsyncLocalStore instance changes the state of another AsyncLocalStore instance by restoring only the owned store instead the complete AsyncContextFrame.

@Flarna
async_hooks: ensure AsyncLocalStore instances work isolated
31fca27 
Avoid that one AsyncLocalStore instance changes the state of another
AsyncLocalStore instance by restoring only the owned store instead
the complete AsyncContextFrame.
@nodejs-github-bot nodejs-github-bot added async_local_storage AsyncLocalStorage needs-ci PRs that need a full CI run. labels May 3, 2025
Flarna
Flarna commented May 3, 2025
View reviewed changes
@Flarna Flarna mentioned this pull request May 3, 2025
Open
@codecov Codecov
Copy link

codecov bot commented May 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (92102c0) to head (7f4ed98).
Report is 28 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58149      +/-   ##
==========================================
- Coverage   90.18%   90.17%   -0.01%     
==========================================
  Files         630      630              
  Lines      186473   186507      +34     
  Branches    36612    36618       +6     
==========================================
+ Hits       168169   168183      +14     
- Misses      11116    11121       +5     
- Partials     7188     7203      +15
Files with missing lines Coverage Δ
...nternal/async_local_storage/async_context_frame.js 100.00% <100.00%> (ø)

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

legendecas
legendecas reviewed May 4, 2025
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this! LGTM

@Flarna Flarna added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels May 4, 2025
@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2025
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66614/

@Flarna Flarna requested a review from Qard May 5, 2025 16:44
@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2025
@nodejs-github-bot nodejs-github-bot merged commit a0d458e into nodejs:main May 6, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a0d458e

@Flarna Flarna deleted the flarna/als-isolated branch May 6, 2025 18:04
targos pushed a commit that referenced this pull request May 16, 2025
@Flarna @targos
async_hooks: ensure AsyncLocalStore instances work isolated
b33e8d2 
Avoid that one AsyncLocalStore instance changes the state of another
AsyncLocalStore instance by restoring only the owned store instead
the complete AsyncContextFrame.

PR-URL: #58149
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@BridgeAR BridgeAR BridgeAR left review comments

@Qard Qard Qard approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
async_local_storage AsyncLocalStorage author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Flarna @nodejs-github-bot @Qard @anonrig @legendecas @BridgeAR