build: escape > metachar in vcbuild #58157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escape the > metachar in vcbuild.bat to avoid that a file named as the major node version number is created.
nodejs-github-bot
added
build
Flarna
added
needs-ci
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14820952587 |
cjihrig
approved these changes
May 4, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
added
commit-queue
StefanStojanovic
approved these changes
May 5, 2025
lpinca
approved these changes
May 5, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in a6bc06f |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
Escape the > metachar in vcbuild.bat to avoid that a file named as the major node version number is created. PR-URL: #58157 Refs: #57991 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape the
>metachar in vcbuild.bat to avoid that a file named as the major node version number is created.Refs: #57991