Skip to content

feat(vite): infer continuous tasks for dev #30043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 14, 2025

Current Behavior

The dev, serve, preview and serve-static targets inferred by the @nx/vite/plugin do not infer continuous:true indicating to Nx that these tasks are continuous.

Expected Behavior

Infer continuous: true for the serve-like targets for Vite.

@Coly010 Coly010 requested a review from a team as a code owner February 14, 2025 10:30
@Coly010 Coly010 self-assigned this Feb 14, 2025
@Coly010 Coly010 requested a review from leosvelperez February 14, 2025 10:30
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 10:32am

Copy link

nx-cloud bot commented Feb 14, 2025

View your CI Pipeline Execution ↗ for commit 8c1db25.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 32m 18s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 21s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 13s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 10s View ↗
nx documentation ✅ Succeeded 1m 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-14 11:08:43 UTC

@Coly010 Coly010 merged commit 7078e97 into next-major Feb 14, 2025
12 checks passed
@Coly010 Coly010 deleted the vite/continuous-tasks branch February 14, 2025 13:08
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants