Skip to content

fix(core): add keepExistingVersions to jest option to preserve dependency versions #30652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

Currently, when we use the jest configuration generator it will forcibly update the jest version if the package already exist.

Expected Behavior

Now, the jest version will be preserved unless the option is passed to update the version.

Related Issue(s)

Fixes #

@ndcunningham ndcunningham self-assigned this Apr 9, 2025
@ndcunningham ndcunningham requested review from a team as code owners April 9, 2025 19:36
Copy link

vercel bot commented Apr 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview May 5, 2025 5:00pm

Copy link

nx-cloud bot commented Apr 9, 2025

View your CI Pipeline Execution ↗ for commit de9c84d.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 32m 2s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 29s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-05 17:26:25 UTC

@ndcunningham ndcunningham merged commit 3b3b320 into master May 7, 2025
6 checks passed
@ndcunningham ndcunningham deleted the fix/jest-versions branch May 7, 2025 16:01
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants