fix(core): use dev tty for crossterm #30696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 7f4afa0.
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
Apr 12, 2025
FrozenPandaz
added a commit
that referenced
this pull request
Apr 12, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> `git push -u origin HEAD` causes the following panic when the TUI is enabled on macos: ``` Backtrace (most recent call last): File "<unknown>:0", in __pthread_cond_wait File "<unknown>:0", in std::sys::pal::unix::thread::Thread::new::thread_start File "<unknown>:0", in core::ops::function::FnOnce::call_once{{vtable.shim}} File "<unknown>:0", in std::sys::backtrace::__rust_begin_short_backtrace File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::scheduler::multi_thread::worker::Context::run_task File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::task::core::Core<T,S>::poll File "<unknown>:0", in nx::native::tui::tui::Tui::start::{{closure}} File "<unknown>:0", in core::option::expect_failed The application panicked (crashed). reader source not set in /Users/jason/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/crossterm-0.29.0/src/event/read.rs:39 thread: tokio-runtime-worker ``` This is due to the fact that crossterm until recently did not use /dev/tty on mac and thus could not read events correctly when forwarded from another program such as husky. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> This adds the `use-dev-tty` features so that `crossterm` utilizes `/dev/tty` and works when forwarded from other programs such as husky on macos. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
FrozenPandaz
added a commit
that referenced
this pull request
Apr 14, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> `git push -u origin HEAD` causes the following panic when the TUI is enabled on macos: ``` Backtrace (most recent call last): File "<unknown>:0", in __pthread_cond_wait File "<unknown>:0", in std::sys::pal::unix::thread::Thread::new::thread_start File "<unknown>:0", in core::ops::function::FnOnce::call_once{{vtable.shim}} File "<unknown>:0", in std::sys::backtrace::__rust_begin_short_backtrace File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::scheduler::multi_thread::worker::Context::run_task File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::task::core::Core<T,S>::poll File "<unknown>:0", in nx::native::tui::tui::Tui::start::{{closure}} File "<unknown>:0", in core::option::expect_failed The application panicked (crashed). reader source not set in /Users/jason/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/crossterm-0.29.0/src/event/read.rs:39 thread: tokio-runtime-worker ``` This is due to the fact that crossterm until recently did not use /dev/tty on mac and thus could not read events correctly when forwarded from another program such as husky. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> This adds the `use-dev-tty` features so that `crossterm` utilizes `/dev/tty` and works when forwarded from other programs such as husky on macos. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
FrozenPandaz
added a commit
that referenced
this pull request
Apr 14, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> `git push -u origin HEAD` causes the following panic when the TUI is enabled on macos: ``` Backtrace (most recent call last): File "<unknown>:0", in __pthread_cond_wait File "<unknown>:0", in std::sys::pal::unix::thread::Thread::new::thread_start File "<unknown>:0", in core::ops::function::FnOnce::call_once{{vtable.shim}} File "<unknown>:0", in std::sys::backtrace::__rust_begin_short_backtrace File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::scheduler::multi_thread::worker::Context::run_task File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::task::core::Core<T,S>::poll File "<unknown>:0", in nx::native::tui::tui::Tui::start::{{closure}} File "<unknown>:0", in core::option::expect_failed The application panicked (crashed). reader source not set in /Users/jason/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/crossterm-0.29.0/src/event/read.rs:39 thread: tokio-runtime-worker ``` This is due to the fact that crossterm until recently did not use /dev/tty on mac and thus could not read events correctly when forwarded from another program such as husky. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> This adds the `use-dev-tty` features so that `crossterm` utilizes `/dev/tty` and works when forwarded from other programs such as husky on macos. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
FrozenPandaz
added a commit
that referenced
this pull request
Apr 14, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> `git push -u origin HEAD` causes the following panic when the TUI is enabled on macos: ``` Backtrace (most recent call last): File "<unknown>:0", in __pthread_cond_wait File "<unknown>:0", in std::sys::pal::unix::thread::Thread::new::thread_start File "<unknown>:0", in core::ops::function::FnOnce::call_once{{vtable.shim}} File "<unknown>:0", in std::sys::backtrace::__rust_begin_short_backtrace File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::scheduler::multi_thread::worker::Context::run_task File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::task::core::Core<T,S>::poll File "<unknown>:0", in nx::native::tui::tui::Tui::start::{{closure}} File "<unknown>:0", in core::option::expect_failed The application panicked (crashed). reader source not set in /Users/jason/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/crossterm-0.29.0/src/event/read.rs:39 thread: tokio-runtime-worker ``` This is due to the fact that crossterm until recently did not use /dev/tty on mac and thus could not read events correctly when forwarded from another program such as husky. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> This adds the `use-dev-tty` features so that `crossterm` utilizes `/dev/tty` and works when forwarded from other programs such as husky on macos. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
FrozenPandaz
added a commit
that referenced
this pull request
Apr 15, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> `git push -u origin HEAD` causes the following panic when the TUI is enabled on macos: ``` Backtrace (most recent call last): File "<unknown>:0", in __pthread_cond_wait File "<unknown>:0", in std::sys::pal::unix::thread::Thread::new::thread_start File "<unknown>:0", in core::ops::function::FnOnce::call_once{{vtable.shim}} File "<unknown>:0", in std::sys::backtrace::__rust_begin_short_backtrace File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::scheduler::multi_thread::worker::Context::run_task File "<unknown>:0", in tokio::runtime::task::raw::poll File "<unknown>:0", in tokio::runtime::task::core::Core<T,S>::poll File "<unknown>:0", in nx::native::tui::tui::Tui::start::{{closure}} File "<unknown>:0", in core::option::expect_failed The application panicked (crashed). reader source not set in /Users/jason/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/crossterm-0.29.0/src/event/read.rs:39 thread: tokio-runtime-worker ``` This is due to the fact that crossterm until recently did not use /dev/tty on mac and thus could not read events correctly when forwarded from another program such as husky. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> This adds the `use-dev-tty` features so that `crossterm` utilizes `/dev/tty` and works when forwarded from other programs such as husky on macos. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
git push -u origin HEADcauses the following panic when the TUI is enabled on macos:This is due to the fact that crossterm until recently did not use /dev/tty on mac and thus could not read events correctly when forwarded from another program such as husky.
Expected Behavior
This adds the
use-dev-ttyfeatures so thatcrosstermutilizes/dev/ttyand works when forwarded from other programs such as husky on macos.Related Issue(s)
Fixes #