Skip to content

fix(core): improve flaky ci test #30738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Apr 15, 2025

This PR updates lerna-smoke-tests.test.ts test file to improve the consistency of the snapshots.
The serializer has been updated to reduce flakiness from spacing and line breaks.

@ndcunningham ndcunningham self-assigned this Apr 15, 2025
Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 6:51pm

Copy link

nx-cloud bot commented Apr 15, 2025

View your CI Pipeline Execution ↗ for commit 7e7a801.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-ci ❌ Failed 1m 45s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-15 19:04:17 UTC

@ndcunningham ndcunningham force-pushed the fix/improve-ci-snapshot-testing branch from 70c984d to a94aef7 Compare April 15, 2025 17:03
@ndcunningham ndcunningham force-pushed the fix/improve-ci-snapshot-testing branch from a94aef7 to ac26122 Compare April 15, 2025 17:55
@ndcunningham ndcunningham force-pushed the fix/improve-ci-snapshot-testing branch from ac26122 to d2bce3f Compare April 15, 2025 18:44
@ndcunningham ndcunningham force-pushed the fix/improve-ci-snapshot-testing branch 3 times, most recently from 4504476 to 4a2ca2f Compare April 16, 2025 16:26
@jaysoo jaysoo force-pushed the fix/improve-ci-snapshot-testing branch from 4a2ca2f to 115cc62 Compare April 16, 2025 16:46
@ndcunningham ndcunningham changed the title fix(core): Improve CI snapshot testing by ignoring new lines diffs fix(core): improve flaky ci test Apr 16, 2025
@ndcunningham ndcunningham force-pushed the fix/improve-ci-snapshot-testing branch from 17bd899 to 635a6e7 Compare April 16, 2025 17:55
@ndcunningham ndcunningham marked this pull request as ready for review April 16, 2025 18:04
@ndcunningham ndcunningham force-pushed the fix/improve-ci-snapshot-testing branch from 635a6e7 to e713aa7 Compare April 16, 2025 18:10
@ndcunningham ndcunningham force-pushed the fix/improve-ci-snapshot-testing branch from e713aa7 to 424c9a1 Compare April 16, 2025 18:49
@jaysoo jaysoo merged commit 8b02fd4 into master Apr 16, 2025
6 checks passed
@jaysoo jaysoo deleted the fix/improve-ci-snapshot-testing branch April 16, 2025 19:08
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants