fix(core): dont cache default plugins as all plugins if loading plugins fails #30927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit d7c8ca0.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Apr 29, 2025
AgentEnder
force-pushed
the
fix/dont-return-default-plugins-on-second-run-daemon
branch
from
9365486 to
02479c9
Compare
AgentEnder
force-pushed
the
fix/dont-return-default-plugins-on-second-run-daemon
branch
from
02479c9 to
76bc523
Compare
AgentEnder
force-pushed
the
fix/dont-return-default-plugins-on-second-run-daemon
branch
from
937f87e to
d7c8ca0
Compare
AgentEnder
deleted the
fix/dont-return-default-plugins-on-second-run-daemon
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Nx 21 adds an error when loading a plugin that's not been updated with
createNodesV2. When attempting to update the Nx repo it was uncovered that there is a bug when loading plugins on the daemon. Because of some improper caching logic ingetPlugins, ifloadSpecifiedNxPluginsthrows the result ofgetDefaultPluginsis cached as if it was the result ofgetPlugins. This causes the error from loading plugins to mysteriously vanish on task reruns with the daemon disabled.Expected Behavior
getDefaultPluginsshould store its cache under its own varRelated Issue(s)
Fixes #