Skip to content

fix(core): write keybindings with control to terminal panes in intera… #30938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

FrozenPandaz
Copy link
Collaborator

…ctive mode

Current Behavior

Ctrl Keybindings are not sent to terminal panes when it's interactive mode, only single key presses are sent.

Expected Behavior

Ctrl Keybindings are sent to the terminal panes when it is in interactive mode. This means that editors like nano and nvim somewhat work in interactive mode. The rendering is still broken right now but the keypresses work.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team as code owners April 30, 2025 01:00
@FrozenPandaz FrozenPandaz requested a review from Cammisuli April 30, 2025 01:00
Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 30, 2025 1:09am

Copy link

nx-cloud bot commented Apr 30, 2025

View your CI Pipeline Execution ↗ for commit 415804e.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-ci ✅ Succeeded 36m 25s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 3m 39s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-30 01:45:52 UTC

@FrozenPandaz FrozenPandaz merged commit d5a1918 into master Apr 30, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-vim branch April 30, 2025 08:36
Copy link

github-actions bot commented May 6, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants