Skip to content

fix(core): return results after NodeChildProcessWithNonDirectOutput has already exited #30943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Apr 30, 2025

Current Behavior

For some mysterious reason, calling getResults after killing a continuous task causes the DTE agent process.. to exit.

Expected Behavior

For some mysterious reason, allowing getResults to return results after the Task has completed fixes the DTE agent process exiting.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner April 30, 2025 14:00
Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2025 10:36pm

Copy link

nx-cloud bot commented Apr 30, 2025

View your CI Pipeline Execution ↗ for commit cc93160.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-ci ✅ Succeeded 3m 19s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-01 00:24:43 UTC

@FrozenPandaz FrozenPandaz changed the title fix(core): do not kill process in dte fix(core): return results after NodeChildProcessWithNonDirectOutput has already exited Apr 30, 2025
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) April 30, 2025 22:45
@FrozenPandaz FrozenPandaz merged commit 912a257 into master May 1, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the no-exit branch May 1, 2025 00:25
Copy link

github-actions bot commented May 7, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants