Skip to content

fix(react): migration for babel supports configs that do not use @nx/react/babel #30962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 30, 2025

This PR fixes an issue where the updated .babelrc is undefined if the @nx/react/babel preset is missing.

@jaysoo jaysoo requested a review from a team as a code owner April 30, 2025 23:10
@jaysoo jaysoo requested a review from Coly010 April 30, 2025 23:10
Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2025 11:15pm

Copy link

nx-cloud bot commented Apr 30, 2025

View your CI Pipeline Execution ↗ for commit 1d4cc18.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-ci ✅ Succeeded 47s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 20s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-30 23:55:00 UTC

@FrozenPandaz FrozenPandaz merged commit 8f50358 into master May 1, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the babel-migration branch May 1, 2025 02:04
Copy link

github-actions bot commented May 7, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants