fix(core): reset should clear cloud light client #31021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 137a43c.
☁️ Nx Cloud last updated this comment at |
AgentEnder
force-pushed
the
fix/core/reset-should-kill-cloud-client
branch
from
ecb5f4f to
137a43c
Compare
FrozenPandaz
approved these changes
May 2, 2025
| @@ -70,7 +80,10 @@ export async function resetHandler(args: ResetCommandOptions) { | |||
| } | |||
| if (all || args.onlyCloud) { | |||
| try { | |||
| await resetCloudClient(); | |||
| if (cloudEnabled) { | |||
There was a problem hiding this comment.
Move into the above condition?
ndcunningham
pushed a commit
that referenced
this pull request
May 5, 2025
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Calling
nx resetdoesn't remove the currently installed cloud light client bundle. Additionally, it creates a .nx/cache/cloud directory even if it doesn't have cloud installed.Expected Behavior
Calling
nx resetdoesn't remove the currently installed cloud light client bundleRelated Issue(s)
Fixes #