Skip to content

fix(core): switch to tui-term fork to support dimmed content #31044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented May 5, 2025

Current Behavior

tui-term cannot render content with the Modifier::Dim because vt100 does not expose this information.

image

Expected Behavior

We use a fork of tui-term which can render dimmed content correctly because our existing vt100 fork now exposes this data to it.

image

Related Issue(s)

Fixes #

Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 5, 2025 4:47pm

Copy link

nx-cloud bot commented May 5, 2025

View your CI Pipeline Execution ↗ for commit 3a90f04.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 35m 27s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 14s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 5m 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-05 17:31:47 UTC

@JamesHenry JamesHenry marked this pull request as ready for review May 5, 2025 16:46
@JamesHenry JamesHenry requested review from a team, FrozenPandaz and vsavkin as code owners May 5, 2025 16:46
@JamesHenry JamesHenry enabled auto-merge (squash) May 5, 2025 16:46
@JamesHenry JamesHenry merged commit e2b27b8 into master May 5, 2025
6 checks passed
@JamesHenry JamesHenry deleted the tui-term-dimmed-contents-support branch May 5, 2025 17:30
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants