Skip to content

fix(core): change default native logging to "OFF" #31161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

Cammisuli
Copy link
Member

Current Behavior

"ERROR" is set as the default logging level when using native logging. This causes issues with the new function of calling the native logger from the JS side.

Expected Behavior

"OFF" is set as the default so that no logs appear on stdout if there was no explicit opt-in.

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested review from a team as code owners May 9, 2025 22:20
@Cammisuli Cammisuli requested review from xiongemi and FrozenPandaz May 9, 2025 22:20
Copy link

vercel bot commented May 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) May 9, 2025 10:20pm

Copy link

nx-cloud bot commented May 9, 2025

View your CI Pipeline Execution ↗ for commit 9c9e02f.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 2m 20s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 19s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-09 23:58:58 UTC

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) May 9, 2025 22:20
@FrozenPandaz FrozenPandaz merged commit ce1d6b2 into master May 9, 2025
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix/change-default-logger-to-off branch May 9, 2025 23:59
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants