fix(gradle): change run and bootRun to cacheable false #31287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit cb8f791.
☁️ Nx Cloud last updated this comment at |
xiongemi
force-pushed
the
fix/gradle-cache-run
branch
from
bc657f0 to
fe0d975
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR makes the Gradle run and bootRun tasks non-cacheable by replacing the hardcoded true cache flag with a conditional check.
- Changed
target["cache"]to useisCacheable(task)instead of alwaystrue - Added
isCacheablehelper to excluderunandbootRuntasks from caching
Comments suppressed due to low confidence (1)
packages/gradle/project-graph/src/main/kotlin/dev/nx/gradle/utils/TaskUtils.kt:314
- [nitpick] Consider adding unit tests for isCacheable to verify it returns false for 'run' and 'bootRun' tasks and true for other task names.
fun isCacheable(task: Task): Boolean {
packages/gradle/project-graph/src/main/kotlin/dev/nx/gradle/utils/TaskUtils.kt
Outdated
Show resolved
Hide resolved
packages/gradle/project-graph/src/main/kotlin/dev/nx/gradle/utils/TaskUtils.kt
Outdated
Show resolved
Hide resolved
FrozenPandaz
approved these changes
May 22, 2025
xiongemi
force-pushed
the
fix/gradle-cache-run
branch
from
fe0d975 to
cb8f791
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
currently, all tasks are cacheable
Expected Behavior
run and bootRun should not be cacheable
Related Issue(s)
Fixes #