fix(nextjs): add extension alias support for handling ESM libs #31323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 5f5760d.
☁️ Nx Cloud last updated this comment at |
ndcunningham
force-pushed
the
fix/nextjs-esm-lib-import
branch
from
9690d47 to
a3d1799
Compare
ndcunningham
force-pushed
the
fix/nextjs-esm-lib-import
branch
from
a3d1799 to
5f5760d
Compare
|
@ndcunningham this fix will also works with turbo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, if you try to import a ESM lib after you generate a Next.js application it fails to build due to how the module exports
export * from './lib/lib8446520.js';.This has been addressed with webpack and needs to be extended to Next.js.
Expected Behavior
You should work out of the box and you should be able to import a lib defined like:
export * from './lib/lib8446520.js';.Related Issue(s)
Fixes #30714