fix(linter): handle ng-package.json file with no lib.entryFile in @nx/enforce-module-boundaries rule
#31360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `enforce-module-boundaries` rule
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 294799d.
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When an
ng-package.jsonfile of an Angular library secondary entry point does not specifylib.entryFile, the@nx/enforce-module-boundariesrule throws an error. Theng-package.jsonfile of an Angular secondary entry point can be as simple as{}, but it would cause the rule to throw an error.Expected Behavior
The
@nx/enforce-module-boundariesrule should correctly handle anng-package.jsonfile of an Angular library secondary entry point that does not specifylib.entryFile. The property should default tosrc/public_api.ts.