Skip to content

Do not sort dictionaries in characterProcessing.listAvailableSymbolDictionaryDefinitions #18178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: beta
Choose a base branch
from
Draft

Do not sort dictionaries in characterProcessing.listAvailableSymbolDictionaryDefinitions #18178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ec6f58
Do not sort dictionaries in `characterProcessing.listAvailableSymbolD…
CyrilleB79 May 28, 2025
a8fff57
Pre-commit auto-fix
pre-commit-ci[bot] May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions source/characterProcessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2010-2024 NV Access Limited, World Light Information Limited,
# Copyright (C) 2010-2025 NV Access Limited, World Light Information Limited,
# Hong Kong Blind Union, Babbage B.V., Julien Cochuyt, Cyrille Bougot, Leonard de Ruijter
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.
Expand All @@ -8,7 +8,6 @@
from enum import IntEnum, StrEnum
from functools import cached_property
import glob
from locale import strxfrm
import os
import codecs
import collections
Expand Down Expand Up @@ -865,10 +864,7 @@ def availableLocales(self) -> dict[str, str]:

def listAvailableSymbolDictionaryDefinitions() -> list[SymbolDictionaryDefinition]:
"""Get available symbol dictionary definitions as initialized in core or in add-ons."""
return sorted(
_symbolDictionaryDefinitions,
key=lambda dct: (dct.source != _SymbolDefinitionSource.BUILTIN, strxfrm(dct.displayName or dct.name)),
)
return list(_symbolDictionaryDefinitions)


def _addSymbolDefinitions():
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ Instead, a `callback` property has been added, which returns a function that per
* `documentationUtils.getDocFilePath` and `installer.getDocFilePath` no longer look for `.txt` files in locale documentation folders. (#17911, @CyrilleB79)
* `config.conf["documentFormatting"]["reportFontAttributes"]` has been removed, use `config.conf["documentFormatting"]["fontAttributeReporting"]` instead. (#18066)
* `config.conf["speech"]["includeCLDR"]` has been removed, check/modify whether `config.conf["speech"]["symbolDictionaries"]` contains `"cldr"` instead. (#18066)
* `characterProcessing.listAvailableSymbolDictionaryDefinitions` do not sort the list of symbol dictionaries anymore to keep the order in which the dictionaries have been added in the list. (#18178, @CyrilleB79)

#### Deprecations

Expand Down