Skip to content

Add new macros + Update RPM constructs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gmbr3
Copy link

@gmbr3 gmbr3 commented Feb 27, 2025

No description provided.

Provide a default value for BRP_PESIGN_COMPRESS_MODULE (pesign-obs-integration)

Signed-off-by: Callum Farmer <[email protected]>
packageand is no longer required since RPM 4.15
Use rpm X and Y syntax instead

Signed-off-by: Callum Farmer <[email protected]>
- Update packageand to X and Y syntax
- Update Prereq to Requires(pre)

Signed-off-by: Callum Farmer <[email protected]>
- Create new macros to make it easier to build for other kernels (longterm etc.)

Signed-off-by: Callum Farmer <[email protected]>
@gmbr3 gmbr3 marked this pull request as draft February 28, 2025 21:36
@gmbr3
Copy link
Author

gmbr3 commented Feb 28, 2025

Needs a slight tweak

gmbr3 added 2 commits March 5, 2025 11:43
They don't require kernel_module_package for expansion
Should also help with rpmbuild spec expansion
kernel_module_package_moddir doesn't need args expansion

Signed-off-by: Callum Farmer <[email protected]>
Useful when building for other flavors (longterm etc.) and
the build uses the flavor build variable from flavors_to_build

Signed-off-by: Callum Farmer <[email protected]>
@gmbr3 gmbr3 marked this pull request as ready for review March 5, 2025 11:45
@hramrach
Copy link
Collaborator

hramrach commented Mar 5, 2025

What's the purpose of this change?

@@ -49,6 +49,45 @@ esac)

%linux_make_arch ARCH=%linux_arch

# no args -> /usr/src/linux
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would this be used for?

This symlink points to some random place. IT should not be used for anything that's intended to be reproducible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's literally the intended symlink for kmp builds
Always points to latest kernel headers

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should point to some kernel source unless something goes wrong.

I don't know where you get the guarantee that it points to the latest. I am not aware of any. Maybe more like last installed.

Supplements: packageand(product(SLED):%{name}_%_target_cpu)
Supplements: packageand(product(sle-we):%{name}_%_target_cpu)
Supplements: packageand(product(Leap):%{name}_%_target_cpu)
Supplements: (product(SLED) and %{name}_%_target_cpu)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since what rpm version is this available?

In particular, dose it work on SLE12 SP5?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires 4.13+ so no SLE12 support

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's no good, SLE12 SP5 is still alive.

@gmbr3
Copy link
Author

gmbr3 commented Mar 5, 2025

What's the purpose of this change?

Ditching RPM syntax that may be dropped from support soon
Making multi flavor kmp builds easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants