Skip to content

Allow searching 1K+ IP/masks in DV-only fields via terms_query #18357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mkhludnev
Copy link
Contributor

@mkhludnev mkhludnev commented May 22, 2025

Description

Avoid clauses limit what searching terms_query for IP/masks over docValues fields.

Related Issues

Resolves #17394

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for bf21595: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 9493dd7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for d88fea8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

mkhludnev added 3 commits May 24, 2025 00:06
Signed-off-by: Mikhail Khludnev <[email protected]>
Signed-off-by: Mikhail Khludnev <[email protected]>
mkhludnev added 2 commits May 24, 2025 00:06
Signed-off-by: Mikhail Khludnev <[email protected]>
Signed-off-by: Mikhail Khludnev <[email protected]>
@mkhludnev mkhludnev force-pushed the GH173394-tmsq-ipmasks-dv0nly branch from 1758202 to 4ad17d8 Compare May 23, 2025 21:07
@mkhludnev mkhludnev marked this pull request as ready for review May 23, 2025 21:09
@mkhludnev mkhludnev changed the title search IP/masks via dvFields search over 1K IP/masks via DV fields May 23, 2025
@mkhludnev mkhludnev changed the title search over 1K IP/masks via DV fields search 1K IP/masks via terms_query over DV-only fields May 23, 2025
@mkhludnev mkhludnev changed the title search 1K IP/masks via terms_query over DV-only fields Allow searching 1K+ IP/masks in DV-only fields via terms_query May 23, 2025
Copy link
Contributor

✅ Gradle check result for 4ad17d8: SUCCESS

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 81.03448% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.63%. Comparing base (aec3fe9) to head (4ad17d8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ava/org/opensearch/index/mapper/IpFieldMapper.java 81.03% 5 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18357      +/-   ##
============================================
+ Coverage     72.52%   72.63%   +0.10%     
- Complexity    67496    67561      +65     
============================================
  Files          5495     5495              
  Lines        311433   311435       +2     
  Branches      45249    45247       -2     
============================================
+ Hits         225867   226210     +343     
+ Misses        67179    66821     -358     
- Partials      18387    18404      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] unlimit IP/masks terms query for doc_values only fields
1 participant