Skip to content

Update OadpSubscription.yaml to the stable channel for 1.5 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

jc-rh
Copy link
Member

@jc-rh jc-rh commented May 26, 2025

No description provided.

@openshift-ci openshift-ci bot requested review from imiller0 and MarSik May 26, 2025 14:39
@jc-rh jc-rh changed the title Update OadpSubscription.yaml to the stable-1.5 channel Update OadpSubscription.yaml to the stable channel for 1.5 May 26, 2025
@jc-rh
Copy link
Member Author

jc-rh commented May 27, 2025

/assign @imiller0 @lack

@@ -6,7 +6,7 @@ metadata:
annotations:
ran.openshift.io/ztp-deploy-wave: "2"
spec:
channel: "stable-1.4"
channel: "stable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this valid for the oadp operator? In 4.18 index I see only stable-1.0 and stable-1.4.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imiller0 I think so. OADP in 4.19 staging catalog only contains "stable" channel. Same as the OADP 1.5 brew builds.
But would be good to confirm with OADP that the channeling mechanism changed starting 1.5.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got confirmation from @jc-rh that OADP is moving to "stable" channel
(ref https://github.com/openshift/oadp-operator/blob/master/PARTNERS.md)

Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -6,7 +6,7 @@ metadata:
annotations:
ran.openshift.io/ztp-deploy-wave: "2"
spec:
channel: "stable-1.4"
channel: "stable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got confirmation from @jc-rh that OADP is moving to "stable" channel
(ref https://github.com/openshift/oadp-operator/blob/master/PARTNERS.md)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
Copy link

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, jc-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit acb31eb into openshift-kni:release-4.19 May 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants