AGENT-1193: Allow access to release info when self-signed cert is used #385
Conversation
Adds --insecure=true to "oc adm release" commands when fetching version and digest. This allows appliance to work with registries that are using self-signed certificates. The alterative would be to pass the self-signed certificates to the appliance when it is operated within a container and then use the --certificate-authority flag when executing "oc adm release".
openshift-ci-robot
added
the
jira/valid-reference
|
@rwsu: This pull request references AGENT-1193 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rwsu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rwsu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -48,8 +48,8 @@ const ( | |||
| PodmanPull = "podman pull %s" | |||
|
|
|||
| // Release | |||
| templateGetVersion = "oc adm release info %s -o template --template '{{.metadata.version}}'" | |||
| templateGetDigest = "oc adm release info %s -o template --template '{{.digest}}'" | |||
| templateGetVersion = "oc adm release info %s -o template --template '{{.metadata.version}}' --insecure=true" | |||
There was a problem hiding this comment.
Just wondering what's the use-case, is it required for tests/CI purposes?
There was a problem hiding this comment.
For local development purposes where we want the appliance to read the ephemeral release payload created by dev-scripts. This may not be needed, in the additionalImages approach so I will put it on hold.
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Adds --insecure=true to "oc adm release" commands when fetching version and digest.
This allows appliance to work with registries that are using self-signed certificates.
The alterative would be to pass the self-signed certificates to the appliance when it is operated within a container and then use the --certificate-authority flag when executing "oc adm release".