-
Notifications
You must be signed in to change notification settings - Fork 98
Update module github.com/onsi/ginkgo/v2 to v2.23.4 #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update module github.com/onsi/ginkgo/v2 to v2.23.4 #386
Conversation
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
302c28c
to
cff6cda
Compare
cff6cda
to
dbe7ce4
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
dbe7ce4
to
0b42247
Compare
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v2.20.2
->v2.23.4
Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
onsi/ginkgo (github.com/onsi/ginkgo/v2)
v2.23.4
Compare Source
2.23.4
Prior to this release Ginkgo would compute the incorrect number of available CPUs when running with
-p
in a linux container. Thanks to @emirot for the fix!Features
2b9c428
]Fixes
1f59d07
]Maintenance
2d134d5
]v2.23.3
Compare Source
2.23.3
Fixes
-
as a standalone argument [cfcc1a5
]feaf292
]88e2282
]v2.23.2
Compare Source
2.23.2
🎉🎉🎉
At long last, some long-standing performance gaps between
ginkgo
andgo test
have been resolved!Ginkgo operates by running
go test -c
to generate test binaries, and then running those binaries. It turns out that the compilation step ofgo test -c
is slower thango test
's compilation step becausego test
strips out debug symbols (ldflags=-w
) whereasgo test -c
does not.Ginkgo now passes the appropriate
ldflags
togo test -c
when running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and whenginkgo build
is called explicitly.This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.
v2.23.1
Compare Source
2.23.1
🚨 For users on MacOS 🚨
A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.
Fixes
Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:
a0e52ff
]b799d8d
]This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.
v2.23.0
Compare Source
2.23.0
Ginkgo 2.23.0 adds a handful of methods to
GinkgoT()
to make it compatible with thetesting.TB
interface in Go 1.24.GinkgoT().Context()
, in particular, is a useful shorthand for generating a new context that will clean itself up in aDeferCleanup()
. This has subtle behavior differences from the golang implementation but should make sense in a Ginkgo... um... context.Features
37a511b
]Fixes
7556a86
]4df06c6
]Maintenance
cbcf39a
]9b261ff
]00f19c8
]e98a4df
]60cc4e2
]fea6f2d
]31d7813
]fc3bbd6
]aee0d56
]809a710
]v2.22.2
Compare Source
What's Changed
Full Changelog: onsi/ginkgo@v2.22.1...v2.22.2
v2.22.1
Compare Source
2.22.1
Fixes
Fix CSV encoding
aab3da6
]c09df39
]96a80fc
]43dad69
]Maintenance
c88c634
]4df44bf
]v2.22.0
Compare Source
2.22.0
Features
0fcaa08
]This allows serial tests to be filtered using the
label-filter
Maintenance
Various doc fixes
v2.21.0
Compare Source
2.21.0
Features
a69eb39
]bcab9c8
]Fixes
e548367
]SpecsThatWillBeRun
withSpecsThatWillRun
[
c2c4d3c
]Maintenance
7e65a00
]Configuration
📅 Schedule: Branch creation - "after 5am on sunday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test
.This PR has been generated by MintMaker (powered by Renovate Bot).