Skip to content

Fix deployment on OCP 4.6 #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

mrogers950
Copy link
Contributor

Check against changing the Service's clusterIP, and retain the existing value as OCP 4.6 does not tolerate that. Later versions just ignore the field.

(same fix as ComplianceAsCode/compliance-operator@404483b)

Check against changing the Service's clusterIP, and retain the existing
value as OCP 4.6 does not tolerate that. Later versions just ignore the
field.
@openshift-ci openshift-ci bot requested review from rhmdnd and Vincent056 October 21, 2022 18:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2022
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I haven't actually tested this, but verified that this is exactly the same patch as for CO.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, mrogers950

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrogers950
Copy link
Contributor Author

/lgtm I haven't actually tested this, but verified that this is exactly the same patch as for CO.

Thanks! I tested this on a 4.6 cluster, and it's all good.

@mrogers950
Copy link
Contributor Author

(Noticed the issue for #292 while testing 4.6.)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2022

@mrogers950: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants