-
Notifications
You must be signed in to change notification settings - Fork 27
AIDE 0.18 e2e #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIDE 0.18 e2e #550
Conversation
32603da
to
8f2292c
Compare
This PR adds the dockerfile that builds operator image with the AIDE 0.18, also replacing 0.16 config file with the 0.18 conf file .
8f2292c
to
35ed92d
Compare
/retest |
Ok - looks good. I only have one minor suggestion on the new e2e suite for AIDE 0.18.0 to make it optional and then we can start exercising it against this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This is passing tests with 0.16.0 and gives us a start for all the 0.18.0 migration work.
Approving so we can get this landed and then land the CI change to incorporate an AIDE 0.18.0 job.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No docs or px needed yet since this is laying down the test plumbing. No functional changes. /px-approved |
@Vincent056: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds the dockerfile that builds operator image with the AIDE 0.18, also replacing 0.16 config file with the 0.18 conf file using the migration logic depends on value of AIDE_VERSION. We will use 0.16 as default value if not set. This is for us to have CI to test AIDE config.
We will need to merge this one and test on openshift/release#54911