Skip to content

AIDE 0.18 e2e #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented Jul 29, 2024

This PR adds the dockerfile that builds operator image with the AIDE 0.18, also replacing 0.16 config file with the 0.18 conf file using the migration logic depends on value of AIDE_VERSION. We will use 0.16 as default value if not set. This is for us to have CI to test AIDE config.

We will need to merge this one and test on openshift/release#54911

@openshift-ci openshift-ci bot requested review from xiaojiey and yuumasato July 29, 2024 09:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@Vincent056 Vincent056 requested a review from rhmdnd July 29, 2024 09:30
This PR adds the dockerfile that builds operator image with the AIDE 0.18,
also replacing 0.16 config file with the 0.18 conf file .
@Vincent056
Copy link
Contributor Author

/retest

@rhmdnd
Copy link
Contributor

rhmdnd commented Aug 6, 2024

Ok - looks good. I only have one minor suggestion on the new e2e suite for AIDE 0.18.0 to make it optional and then we can start exercising it against this PR.

Copy link
Contributor

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is passing tests with 0.16.0 and gives us a start for all the 0.18.0 migration work.

Approving so we can get this landed and then land the CI change to incorporate an AIDE 0.18.0 job.

openshift/release#54911

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd
Copy link
Contributor

rhmdnd commented Aug 9, 2024

No docs or px needed yet since this is laying down the test plumbing. No functional changes.

/px-approved
/docs-approved

@rhmdnd rhmdnd added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 9, 2024
Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

@Vincent056: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a70afbc into openshift:master Aug 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants