-
Notifications
You must be signed in to change notification settings - Fork 27
Use latest in the CSV instead of a version tag #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest in the CSV instead of a version tag #577
Conversation
This makes it so that the replace logic also replaces the deployment image in addition to the related image. This is necessary CI to work properly, because it needs to be able to replace all images in the CSV with a build from CI.
This seems to work, but there were a lot of test failures, 😢 |
/test e2e-bundle-aws |
Yes, I think we need this change. But we also need this change in the FIO release PR too. |
/retest-required |
I have cherry-picked this commit to the release PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws |
3 similar comments
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
04aeb43
into
openshift:master
This makes it so that the replace logic also replaces the deployment
image in addition to the related image. This is necessary CI to work
properly, because it needs to be able to replace all images in the CSV
with a build from CI.