Skip to content

Ibmcloud router #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

Conversation

libesz
Copy link

@libesz libesz commented May 14, 2025

What this PR does / why we need it:

When HCP contains router publish strategy for the
master services, IBM Cloud platform implementation
will take care of the proper exposure of the
services, without using the actual cluster Router
(similar implementation to Azure). That is, CPO should
not create any LoadBalancer or actual router deployment
as part of reconciling the HCP.
The current change also makes the migration from NodePort
services backward compatible, for existing clusters.
That is, the NodePort services will remain as is
(they are not converted to regular ClusterIP services,
resulting in permanently losing the reserved nodeports)
allowing existing external clients (e.g. kubelet,
master proxy) to work as before, until they are also
upgraded.

The expected behavior is to:

  • Do not manage any ingress component (LB Svc, Router)
  • Keep NodePort master services (if they are already existing)
  • (Re)configure node agents (e.g. connectivity) to use 443 as server port

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-area area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/needs-area labels May 14, 2025
Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: libesz
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 14, 2025

Hi @libesz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@libesz libesz force-pushed the ibmcloud-router branch from 14f069b to 88928a8 Compare May 22, 2025 14:41
When HCP contains router publish strategy for the
master services, IBM Cloud platform implementation
will take care of the proper exposure of the
services, without using the actual cluster Router
(similar implementation to Azure). That is, CPO should
not create any LoadBalancer or actual router deployment
as part of reconciling the HCP.
The current change also makes the migration from NodePort
services backward compatible, for existing clusters.
That is, the NodePort services will remain as is
(they are not converted to regular ClusterIP services,
resulting in permanently losing the reserved nodeports)
allowing existing external clients (e.g. kubelet,
master proxy) to work as before, until they are also
upgraded.

The expected behavior is to:
* Do not manage any ingress component (LB Svc, Router)
* Keep NodePort master services (if they are already existing)
* (Re)configure node agents (e.g. connectivity) to use 443 as server port
@libesz libesz force-pushed the ibmcloud-router branch from cb7cfb6 to 7e4268c Compare May 27, 2025 12:46
@libesz libesz marked this pull request as ready for review May 27, 2025 12:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2025
@openshift-ci openshift-ci bot requested review from csrwng and isco-rodriguez May 27, 2025 12:49
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open this PR on the main branch.

@libesz
Copy link
Author

libesz commented May 28, 2025

There it is: #6199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants