-
Notifications
You must be signed in to change notification settings - Fork 374
MGMT-20682: Enable disabling of Console capability #6183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MGMT-20682: Enable disabling of Console capability #6183
Conversation
@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: linoyaslan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6197c5a
to
0c8a121
Compare
fc50b9c
to
46aa411
Compare
054418e
to
c6dc38c
Compare
@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
c6dc38c
to
2ead0fa
Compare
Let's update the PR to include support for only one new capability. Then please let's add e2e validation for it within TestCreateClusterCustomConfig, see EnsureImageRegistryCapabilityDisabled as an example. These capabilities should be more straight forward if they don't have management side implications |
Test Resultse2e-aws
Failed TestsTotal failed tests: 2
e2e-aks
|
@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
087bb7e
to
c140888
Compare
c140888
to
5f74f8c
Compare
/retest-required |
5f74f8c
to
7e2fe31
Compare
This commit is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.
7e2fe31
to
4f156e7
Compare
@linoyaslan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold |
What this PR does / why we need it:
This PR is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.
Checklist