Skip to content

MGMT-20682: Enable disabling of Console capability #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

linoyaslan
Copy link

@linoyaslan linoyaslan commented May 22, 2025

What this PR does / why we need it:
This PR is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2025

@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

This PR is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console and OpenShiftSamples capabilities, both managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@linoyaslan linoyaslan marked this pull request as draft May 22, 2025 14:54
@openshift-ci openshift-ci bot added do-not-merge/needs-area do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 22, 2025
@openshift-ci openshift-ci bot requested review from csrwng and rtheis May 22, 2025 14:55
@openshift-ci openshift-ci bot added the area/api Indicates the PR includes changes for the API label May 22, 2025
Copy link
Contributor

openshift-ci bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: linoyaslan
Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels May 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2025

@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
This PR is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console and OpenShiftSamples capabilities, both managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch 3 times, most recently from 6197c5a to 0c8a121 Compare May 26, 2025 10:15
@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch 2 times, most recently from fc50b9c to 46aa411 Compare May 26, 2025 12:13
@linoyaslan linoyaslan marked this pull request as ready for review May 26, 2025 12:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2025
@openshift-ci openshift-ci bot requested review from enxebre and hasueki May 26, 2025 12:15
@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch 2 times, most recently from 054418e to c6dc38c Compare May 26, 2025 12:51
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 26, 2025

@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
This PR is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console and OpenShiftSamples capabilities, both managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch from c6dc38c to 2ead0fa Compare May 26, 2025 12:58
@enxebre
Copy link
Member

enxebre commented May 26, 2025

Let's update the PR to include support for only one new capability. Then please let's add e2e validation for it within TestCreateClusterCustomConfig, see EnsureImageRegistryCapabilityDisabled as an example. These capabilities should be more straight forward if they don't have management side implications

@cwbotbot
Copy link

cwbotbot commented May 26, 2025

Test Results

e2e-aws

Failed Tests

Total failed tests: 2

  • TestCreateClusterCustomConfig
  • TestCreateClusterCustomConfig/ValidateHostedCluster

e2e-aks

@linoyaslan linoyaslan changed the title MGMT-20682: Enable disabling of Console and OpenShiftSamples capabilities MGMT-20682: Enable disabling of Console capability May 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 27, 2025

@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
This PR is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch 2 times, most recently from 087bb7e to c140888 Compare May 27, 2025 09:51
@openshift-ci openshift-ci bot added the area/testing Indicates the PR includes changes for e2e testing label May 27, 2025
@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch from c140888 to 5f74f8c Compare May 27, 2025 10:17
@linoyaslan
Copy link
Author

/retest-required

@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch from 5f74f8c to 7e2fe31 Compare May 27, 2025 10:24
This commit is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.
@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch from 7e2fe31 to 4f156e7 Compare May 27, 2025 13:47
Copy link
Contributor

openshift-ci bot commented May 27, 2025

@linoyaslan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 4f156e7 link true /test e2e-aws
ci/prow/e2e-aws-4-19 4f156e7 link true /test e2e-aws-4-19

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@linoyaslan
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants