OCPBUGS-56492: Fix CatalogSource image check when unauthorized #6192
Conversation
openshift-ci-robot
added
jira/severity-critical
|
@jparrill: This pull request references Jira Issue OCPBUGS-56492, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
area/control-plane-operator
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@jparrill: This pull request references Jira Issue OCPBUGS-56492, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Test Resultse2e-aws
e2e-aks
|
|
/lgtm |
|
/hold Until the fallback image of the OLM catalogs is set to the original one. |
openshift-ci
bot
added
the
do-not-merge/hold
This PR fixes 3 issues: - Failing and blocking the HostedCluster provisioning when a needed image is unauthorized to be pulled - Overriding the registry once an entry matches just the registry root on the catalogSources - Fallback on the original ImageReference once the registryOverrides does not work as expected. Also includes the test case testing the fallback of a unauthorized pull of an image and the refactor of a test function to be mantible and readable Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>
|
@jparrill: This pull request references Jira Issue OCPBUGS-56492, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, sdminonne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Konflux and AKS... |
|
/retest Konflux |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@jparrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest Konflux again... |
|
/lgtm |
|
/retest |
| defaultRegistryURL := "registry.redhat.io" | ||
| defaultRegistryNamespace := "redhat" |
There was a problem hiding this comment.
can we move those to a constant at the beginning of the file for visibility?
There was a problem hiding this comment.
I'll do in a follow up PR. This blocks the disconnected testing on QE
|
/retest |
|
/override Red Hat Konflux / hypershift-operator-main-on-pull-request |
|
@celebdor: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request" |
|
@celebdor: Overrode contexts on behalf of celebdor: Red Hat Konflux / hypershift-operator-main-on-pull-request In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main" |
|
@celebdor: Overrode contexts on behalf of celebdor: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit c256d32
into
openshift:main
|
@jparrill: Jira Issue OCPBUGS-56492: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-56492 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira backport release-4.19 |
|
@jparrill: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: new pull request created: #6198 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: hypershift |
What this PR does / why we need it
This PR fixes 3 issues:
It also includes the test case testing the fallback of a unauthorized pull of an image and the refactor of a test function to be mantible and readable
Which issue(s) this PR fixes