Skip to content

registry image reports "unknown" openshift version #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bparees opened this issue Dec 11, 2017 · 4 comments
Closed

registry image reports "unknown" openshift version #26

bparees opened this issue Dec 11, 2017 · 4 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@bparees
Copy link
Contributor

bparees commented Dec 11, 2017

time="2017-12-11T18:50:48.773847179Z" level=info msg="start registry" distribution_version="v2.6.2+unknown" go.version=go1.8.3 instance.id=0bfa960a-ac57-4138-abf9-f9445aa5eed7 kubernetes_version=v1.7.6+$Format:%h$ openshift_version=unknown

@bparees bparees added the kind/bug Categorizes issue or PR as related to a bug. label Dec 11, 2017
@bparees
Copy link
Contributor Author

bparees commented Dec 11, 2017

the kubernetes version output is also messed up:
kubernetes_version=v1.7.6+$Format:%h$

at a minimum the "Format" shouldn't be there (should be a git commit).

@dmage
Copy link
Contributor

dmage commented Dec 11, 2017

That is expected output, we need to remove dependencies on origin and I'm going to remove this fields at all, because they are for origin. What do you expect to see there?

@bparees
Copy link
Contributor Author

bparees commented Dec 11, 2017

That is expected output, we need to remove dependencies on origin and I'm going to remove this fields at all, because they are for origin. What do you expect to see there?

Well i think we need to discuss as an org what we expect (should the image-registry report a consistent version like "v3.9" itself? if so, should it get that value from a common location rather than each repo having to maintain/bump the version itself?)

But at a minimum i'd expect/want the git commit that was used to build the image.

So openshift_registry_version=vX.Y+commitid is what i'd expect/want.

Where the source of X.Y is TBD.

@bparees
Copy link
Contributor Author

bparees commented Dec 11, 2017

@smarterclayton what's the plan for providing common version numbers to different components like this? Is the build tooling supposed to handle it for us? Some other mechanism?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Development

No branches or pull requests

2 participants