Add pkg/version

[dmage]

/assign @bparees
Resolves #26

[bparees]

lgtm but is our build process actually populating those fields?

[bparees]

that is, is -ldflags being set in our build process?

[dmage]

Yes,

image-registry/hack/lib/constants.sh

Lines 59 to 63 in c540fa0

	ldflags+=($(os::build::ldflag "${OS_GO_PACKAGE}/pkg/version.majorFromGit" "${OS_GIT_MAJOR}"))
	ldflags+=($(os::build::ldflag "${OS_GO_PACKAGE}/pkg/version.minorFromGit" "${OS_GIT_MINOR}"))
	ldflags+=($(os::build::ldflag "${OS_GO_PACKAGE}/pkg/version.versionFromGit" "${OS_GIT_VERSION}"))
	ldflags+=($(os::build::ldflag "${OS_GO_PACKAGE}/pkg/version.commitFromGit" "${OS_GIT_COMMIT}"))
	ldflags+=($(os::build::ldflag "${OS_GO_PACKAGE}/pkg/version.buildDate" "${buildDate}"))

[bparees]

cool, thanks.

[bparees]

/retest

[bparees]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [bparees,dmage]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[dmage]

@bparees looks like the extended test is broken.

[bparees]

@bparees looks like the extended test is broken.

or flaked anyway. are you looking into it?

[dmage]

issue for extended tests: openshift/origin#17786

[dmage]

/retest