Skip to content

IBI generate a containerfile #9682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

omertuc
Copy link
Contributor

@omertuc omertuc commented Apr 28, 2025

Background / Context

With openshift-kni/lifecycle-agent#815 we can generate seed images that are also bootc images. Using a simple Containerfile, we can FROM these images, add a cluster configuration, and get a fully bootable cluster

Issue / Requirement / Reason for change

This Containerfile needs to be written manually

Solution / Feature Overview

The installer can help the user write this Containerfile.

Implementation Details

We add a new subcommand, containerfile, to the image-based create command.

This command is similar to the config-image command, but instead of generating an ISO, it generates a Containerfile that can be used to build the configured-seed image.

Other Information

  • The installer does not actually build the image, this is left to the user. The installer only generates the Containerfile.

  • The Containerfile currently needs to extract the tars. This is unnecessary, the lifecycle-agent should already do that during the seed build. There's no point in having those tars inside the image.

  • Changed some other unrelated IBI code to leverage Go's embed

# Background / Context

With openshift-kni/lifecycle-agent#815 we can
generate seed images that are also bootc images. Using a simple
`Containerfile`, we can FROM these images, add a cluster configuration,
and get a fully bootable cluster

# Issue / Requirement / Reason for change

This Containerfile needs to be written manually

# Solution / Feature Overview

The installer can help the user write this Containerfile.

# Implementation Details

We add a new subcommand, `containerfile`, to the `image-based create`
command.

This command is similar to the config-image command, but instead of
generating an ISO, it generates a Containerfile that can be used to
build the configured-seed image.

# Other Information

- The installer does not actually build the image, this is left to the
  user. The installer only generates the Containerfile.

- The Containerfile currently needs to extract the tars. This is
  unnecessary, the lifecycle-agent should already do that during the
  seed build. There's no point in having those tars inside the image.

- Changed some other unrelated IBI code to leverage Go's `embed`
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2025
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tthvo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 7, 2025

@omertuc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant