CORS-3998: Remove base domain from metadata #9711
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rna-afk: This pull request references CORS-3998 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
IIUC this is just reverting #9365 and not proposing an alternate fix? That is fine, just want to make sure I understand. I suggested that we could glean the name from the private dns zone, but I realize by the nature of this bug, the private DNS zone has been destroyed. 🤦 So I agree with your conclusion, it seems like in this scenario, we cannot determine zone/record. Because Azure DNS records allow tags, it should be do-able for clients to setup automation to scrub leaked records. |
Since HIVE finds it real hard to add extra field to the metadata, adding this base domain causes things to crash at their end. Removing the base domain field from the metadata. The base domain field was added to the metadata for the sole purpose of checking the public dns zone for any stray records of a cluster. This only happens if the user deletes the resource group of the cluster instead of running destroy cluster through the installer. Ascertaining the public record is going to be a real tough task without passing the value through the metadata and hence, choosing the bug with the lower probability. This reverts commit 9f392fa.
rna-afk
force-pushed
the
remove_base_domain_metadata
branch
from
ebf61da to
153366e
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
Since HIVE finds it real hard to add extra field to the metadata, adding this base domain causes things to crash at their end. Removing the base domain field from the metadata.
The base domain field was added to the metadata for the sole purpose of checking the public dns zone for any stray records of a cluster. This only happens if the user deletes the resource group of the cluster instead of running destroy cluster through the installer.
Ascertaining the public record is going to be a real tough task without passing the value through the metadata and hence, choosing the bug with the lower probability.
This reverts commit 9f392fa.