Skip to content

NO-JIRA: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

NO-JIRA: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. #2287

merged 1 commit into from
May 7, 2025

Conversation

benluddy
Copy link

@benluddy benluddy commented May 6, 2025

We inadvertently began serving these in the default feature set beginning with 4.17.0. We intend to stop serving them in 4.20.0 and to treat this as a typical deprecated API removal.

@benluddy
UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as depre…
f959e46 
…cated.

We inadvertently began serving these in the default feature set beginning with 4.17.0. We intend to
stop serving them in 4.20.0 and to treat this as a typical deprecated API removal.
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 6, 2025
@openshift-ci-robot
Copy link

@benluddy: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and tkashem May 6, 2025 18:10
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@benluddy
Copy link
Author

benluddy commented May 6, 2025

/cc @bertinatto

@openshift-ci openshift-ci bot requested a review from bertinatto May 6, 2025 18:14
@benluddy
Copy link
Author

benluddy commented May 6, 2025

/cherry-pick release-4.19 release-4.18

@openshift-cherrypick-robot
Copy link

@benluddy: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

bertinatto
bertinatto reviewed May 6, 2025
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label backports/unvalidated-commits
/label backports/validated-commits
/lgtm

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels May 6, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@bertinatto
Copy link
Member

/retest-required

1 similar comment
@benluddy
Copy link
Author

benluddy commented May 6, 2025

/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benluddy
Copy link
Author

benluddy commented May 7, 2025

/test e2e-aws-ovn-serial

Tests passed here but the job timed out while deprovisioning.

@benluddy benluddy changed the title UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. NO-JIRA: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. May 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2025
@openshift-ci-robot
Copy link

@benluddy: This pull request explicitly references no jira issue.

In response to this:

We inadvertently began serving these in the default feature set beginning with 4.17.0. We intend to stop serving them in 4.20.0 and to treat this as a typical deprecated API removal.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 7, 2025 •
edited
Loading

@benluddy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn f959e46 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-agnostic-ovn-cmd f959e46 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD aa347f0 and 2 for PR HEAD f959e46 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 00030d3 into openshift:master May 7, 2025
20 of 22 checks passed
@openshift-cherrypick-robot
Copy link

@benluddy: new pull request created: #2290

In response to this:

/cherry-pick release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 7, 2025
Open
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.20.0-202505080144.p0.g00030d3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.20.0-202505080144.p0.g00030d3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.20.0-202505080144.p0.g00030d3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.20.0-202505080144.p0.g00030d3.assembly.stream.el9.
All builds following this will include this PR.

@xueqzhan xueqzhan mentioned this pull request May 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@tkashem tkashem Awaiting requested review from tkashem

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benluddy @openshift-ci-robot @openshift-cherrypick-robot @bertinatto @openshift-bot