TRT-1854: remove annotation rules that don't relate to suites #2299
Conversation
openshift-ci-robot
added
backports/unvalidated-commits
|
@smg247: This pull request references TRT-1854 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smg247 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
smg247
force-pushed
the
remove-non-suite-annotations
branch
from
0c5f28d to
678dbb4
Compare
|
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/test verify |
|
@smg247: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
smg247
force-pushed
the
remove-non-suite-annotations
branch
from
678dbb4 to
8ef4216
Compare
|
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload 4.20 nightly blocking |
|
@smg247: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/42c73990-371c-11f0-809f-18205a647f52-0 |
|
/retest-required |
|
/payload 4.20 nightly blocking |
|
@smg247: trigger 14 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/af0d4690-3ae5-11f0-8ce1-0abd804db024-0 |
These rules have been redundant since the environment selectors have been added to the external binary. We have been waiting to figure out how to map the old test names to the new ones for the sake of keeping the historical results together. openshift-eng/ci-test-mapping#282 handles that. We still need the suite information to be added to the test name, however, as suites aren't fully implemented in
origin. Once that is completed, the entire annotation framework will be removed.Note that there were also some
sigannotations here that are being removed, but when I checked which tests they were being applied to I wasn't able to find any. I believe they are old, irrelevant, and safe to delete.