Skip to content

[Test] openai-e2e: change model #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Test] openai-e2e: change model #2454

wants to merge 1 commit into from

Conversation

asamal4
Copy link
Contributor

@asamal4 asamal4 commented Apr 22, 2025 •
edited
Loading

OLS-1657
Testing with different gpt models

@asamal4
Copy link
Contributor Author

asamal4 commented Apr 22, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2025
@openshift-ci openshift-ci bot requested review from tisnik and xrajesh April 22, 2025 09:34
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asamal4
Copy link
Contributor Author

asamal4 commented Apr 22, 2025

checking flakiness - iteration 3 (prev 2 passed)
/test 4.18-e2e-ols-cluster

@asamal4 asamal4 mentioned this pull request Apr 22, 2025
Merged
@asamal4
Copy link
Contributor Author

asamal4 commented Apr 23, 2025

checking flakiness - iteration 4 (prev 3 passed)
/test 4.18-e2e-ols-cluster

JoaoFula
JoaoFula reviewed Apr 23, 2025
View reviewed changes
tests/e2e/test_query_endpoint.py
@@ -348,7 +450,6 @@ def test_token_counters_for_query_call_with_improper_payload() -> None:

@pytest.mark.introspection
@pytest.mark.rag
@retry(max_attempts=3, wait_between_runs=10)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need the retry under test_rag_question as it's been one of our flakiest tests. The retry is what has been getting it to pass.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: It's happening due to exceeding query limits for azure_openai. We can try to ask Microsoft about this but if the retry can be there, I'd say it's probably easier to handle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know.. This PR is not final yet..
I am running it multiple times to see if we are still getting error or not (and for which model).. so removed all retries..

I will revert this in this PR itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okok, thank you!

@asamal4 asamal4 changed the title openai-e2e: change model [WIP] openai-e2e: change model Apr 23, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2025
@asamal4
Copy link
Contributor Author

asamal4 commented Apr 23, 2025

checking flakiness - iteration 5 (prev 3/4 passed)
/test 4.18-e2e-ols-cluster

@asamal4 asamal4 force-pushed the OLS-1657 branch 3 times, most recently from 29755fa to 6b1d21d Compare April 25, 2025 05:09
@asamal4
Copy link
Contributor Author

asamal4 commented Apr 25, 2025 •
edited
Loading 

Summary for reject ocp: 
4 (0/9), 4o (1/10), 4o-mini (4/10), 4.1 (0/10)
Summary for other issue:
4 (1/10), 4o (0/10), 4o-mini (0/10), 4.1 (0/10)

/test 4.18-e2e-ols-cluster

@asamal4 asamal4 force-pushed the OLS-1657 branch 4 times, most recently from 0b3afd7 to 6c811e0 Compare April 29, 2025 08:02
@asamal4 asamal4 changed the title [WIP] openai-e2e: change model [Test] openai-e2e: change model Apr 29, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 26, 2025

@asamal4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.18-e2e-ols-cluster dd96ff9 link true /test 4.18-e2e-ols-cluster
ci/prow/unit dd96ff9 link true /test unit
ci/prow/verify dd96ff9 link true /test verify
ci/prow/integration dd96ff9 link true /test integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoFula JoaoFula JoaoFula left review comments

@tisnik tisnik Awaiting requested review from tisnik

@xrajesh xrajesh Awaiting requested review from xrajesh

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asamal4 @openshift-merge-robot @JoaoFula