Skip to content

OLS-1673: Use road-core as dep #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

onmete
Copy link
Contributor

@onmete onmete commented May 6, 2025

Description

Using road-core as a dependency and leaving OLS as a configuration of such.

Breaking change (couldn't be bigger :)).

TODO:

  • docs
  • tests
  • ...

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025

@onmete: This pull request references OLS-1673 which is a valid jira issue.

In response to this:

Description

Using road-core as a dependency and leaving OLS as a configuration of such.

Breaking change (couldn't be bigger :)).

TODO:

  • docs
  • tests
  • ...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bparees and joshuawilson May 6, 2025 12:15
Copy link

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onmete
Copy link
Contributor Author

onmete commented May 6, 2025

/test images

@onmete onmete force-pushed the road-in-ols branch 2 times, most recently from 33a6502 to 387466c Compare May 7, 2025 13:27
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2025
@onmete onmete force-pushed the road-in-ols branch 2 times, most recently from a8ed48c to 4df9cdb Compare May 9, 2025 06:45
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2025
@onmete
Copy link
Contributor Author

onmete commented May 9, 2025

/test 4.18-e2e-ols-cluster

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2025
@onmete
Copy link
Contributor Author

onmete commented May 9, 2025

/test 4.18-e2e-ols-cluster

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented May 26, 2025

@onmete: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.18-ols-evaluation 79b5a8b link true /test 4.18-ols-evaluation
ci/prow/4.18-e2e-ols-cluster 79b5a8b link true /test 4.18-e2e-ols-cluster
ci/prow/integration 79b5a8b link true /test integration
ci/prow/verify 79b5a8b link true /test verify
ci/prow/unit 79b5a8b link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants