Skip to content

[Test] add custom weights to rag indexes #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asamal4
Copy link
Contributor

@asamal4 asamal4 commented May 21, 2025

Description

Override query fusion class to use weights as it is instead of normalized weighted score.
This is currently an experimental/easy work-around to prioritize indexes.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2025
Copy link

openshift-ci bot commented May 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@asamal4
Copy link
Contributor Author

asamal4 commented May 21, 2025

/test all

Copy link

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asamal4 asamal4 changed the title Add custom weights to rag indexes [Test] add custom weights to rag indexes May 21, 2025
@asamal4
Copy link
Contributor Author

asamal4 commented May 22, 2025

/retest

@asamal4
Copy link
Contributor Author

asamal4 commented May 26, 2025

/test all

@asamal4 asamal4 marked this pull request as ready for review May 26, 2025 09:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2025
@openshift-ci openshift-ci bot requested review from joshuawilson and xrajesh May 26, 2025 09:35
@asamal4 asamal4 force-pushed the LCORE-146 branch 2 times, most recently from 8e59780 to 4b8f8a7 Compare May 26, 2025 09:37
@asamal4
Copy link
Contributor Author

asamal4 commented May 26, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2025
Copy link

openshift-ci bot commented May 26, 2025

@asamal4: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant